Use allenh1/ros_gentoo_base for Docker #122
Conversation
|
It does seem to make sense to collapse those two images together. Might it make sense however to move that image here? Otherwise you'll end up with cross coupling if you want to fork this repo, and then have to fork that image and then redirect to use the alternative version. Versus if it was here it could build it in the case that it's not already hosted. |
That's a good idea. Maybe it should be in its own repo and used as a git submodule? I feel that it doesn't really belong in either repo. |
|
Submodules I've found are often a problem but might work in this case. Though I think that you actually have different use cases. One is the boostrap tool for superflore, and one is a generic base image for users to be able to build on top of. They may be very similar but I don't know that they necessarily will want to maintain all changes on both sides so maintaining them in parallel might make sense. PS where's the source for that image. I couldn't find it in a quick search. |
Maybe the solution would then be to close this PR and to host the repoman_docker image?
You can find the source for it in the ROS-Overlay repo. |
…one (as this Dockerfile is a subset of the other).
allenh1
force-pushed
the
use-gentoo-base-docker
branch
from
449bb7c to
60dee0d
Compare
* Pull the docker image we use for testing instead of building a fresh one (as this Dockerfile is a subset of the other). * Remove repoman_docker
It occurred to me that we really don't need to have two docker images anymore, since the other can just be pulled down when needed.
As such, this simply removes the
repoman_dockerimage, as it's a subset of the Dockerfile used to generateallenh1/ros_gentoo_base.